diff --git a/source/App/EncoderApp/EncAppCfg.cpp b/source/App/EncoderApp/EncAppCfg.cpp index 782161fdd0336b55a1a33bb599557ef24af0fa21..4cc0bd361e93a8cb7f1769b074dbb6647de6dd85 100644 --- a/source/App/EncoderApp/EncAppCfg.cpp +++ b/source/App/EncoderApp/EncAppCfg.cpp @@ -2270,74 +2270,44 @@ bool EncAppCfg::parseCfg( int argc, char* argv[] ) int qpBdOffsetC = 6 * (m_internalBitDepth[CHANNEL_TYPE_CHROMA] - 8); m_chromaQpMappingTableParams.m_deltaQpInValMinus1[0].resize(cfg_qpInValCb.values.size()); m_chromaQpMappingTableParams.m_deltaQpOutVal[0].resize(cfg_qpOutValCb.values.size()); -#if JVET_P0410_CHROMA_QP_MAPPING m_chromaQpMappingTableParams.m_numPtsInCQPTableMinus1[0] = (cfg_qpOutValCb.values.size() > 1) ? (int)cfg_qpOutValCb.values.size() - 2 : 0; m_chromaQpMappingTableParams.m_qpTableStartMinus26[0] = (cfg_qpOutValCb.values.size() > 1) ? -26 + cfg_qpInValCb.values[0] : 0; CHECK(m_chromaQpMappingTableParams.m_qpTableStartMinus26[0] < -26 - qpBdOffsetC || m_chromaQpMappingTableParams.m_qpTableStartMinus26[0] > 36, "qpTableStartMinus26[0] is out of valid range of -26 -qpBdOffsetC to 36, inclusive.") CHECK(cfg_qpInValCb.values[0] != cfg_qpOutValCb.values[0], "First qpInValCb value should be equal to first qpOutValCb value"); for (int i = 0; i < cfg_qpInValCb.values.size() - 1; i++) -#else - m_chromaQpMappingTableParams.m_numPtsInCQPTableMinus1[0] = (int)cfg_qpOutValCb.values.size()-1; - for (int i = 0; i < cfg_qpInValCb.values.size(); i++) -#endif { CHECK(cfg_qpInValCb.values[i] < -qpBdOffsetC || cfg_qpInValCb.values[i] > MAX_QP, "Some entries cfg_qpInValCb are out of valid range of -qpBdOffsetC to 63, inclusive."); CHECK(cfg_qpOutValCb.values[i] < -qpBdOffsetC || cfg_qpOutValCb.values[i] > MAX_QP, "Some entries cfg_qpOutValCb are out of valid range of -qpBdOffsetC to 63, inclusive."); -#if JVET_P0410_CHROMA_QP_MAPPING m_chromaQpMappingTableParams.m_deltaQpInValMinus1[0][i] = cfg_qpInValCb.values[i + 1] - cfg_qpInValCb.values[i] - 1; m_chromaQpMappingTableParams.m_deltaQpOutVal[0][i] = cfg_qpOutValCb.values[i + 1] - cfg_qpOutValCb.values[i]; -#else - m_chromaQpMappingTableParams.m_deltaQpInValMinus1[0][i] = (i == 0) ? cfg_qpInValCb.values[i] + qpBdOffsetC : cfg_qpInValCb.values[i] - cfg_qpInValCb.values[i - 1] - 1; - m_chromaQpMappingTableParams.m_deltaQpOutVal[0][i] = (i == 0) ? cfg_qpOutValCb.values[i] + qpBdOffsetC : cfg_qpOutValCb.values[i] - cfg_qpOutValCb.values[i - 1]; -#endif } if (!m_chromaQpMappingTableParams.m_sameCQPTableForAllChromaFlag) { m_chromaQpMappingTableParams.m_deltaQpInValMinus1[1].resize(cfg_qpInValCr.values.size()); m_chromaQpMappingTableParams.m_deltaQpOutVal[1].resize(cfg_qpOutValCr.values.size()); -#if JVET_P0410_CHROMA_QP_MAPPING m_chromaQpMappingTableParams.m_numPtsInCQPTableMinus1[1] = (cfg_qpOutValCr.values.size() > 1) ? (int)cfg_qpOutValCr.values.size() - 2 : 0; m_chromaQpMappingTableParams.m_qpTableStartMinus26[1] = (cfg_qpOutValCr.values.size() > 1) ? -26 + cfg_qpInValCr.values[0] : 0; CHECK(m_chromaQpMappingTableParams.m_qpTableStartMinus26[1] < -26 - qpBdOffsetC || m_chromaQpMappingTableParams.m_qpTableStartMinus26[1] > 36, "qpTableStartMinus26[1] is out of valid range of -26 -qpBdOffsetC to 36, inclusive.") CHECK(cfg_qpInValCr.values[0] != cfg_qpOutValCr.values[0], "First qpInValCr value should be equal to first qpOutValCr value"); for (int i = 0; i < cfg_qpInValCr.values.size() - 1; i++) -#else - m_chromaQpMappingTableParams.m_numPtsInCQPTableMinus1[1] = (int)cfg_qpOutValCr.values.size()-1; - for (int i = 0; i < cfg_qpInValCr.values.size(); i++) -#endif { CHECK(cfg_qpInValCr.values[i] < -qpBdOffsetC || cfg_qpInValCr.values[i] > MAX_QP, "Some entries cfg_qpInValCr are out of valid range of -qpBdOffsetC to 63, inclusive."); CHECK(cfg_qpOutValCr.values[i] < -qpBdOffsetC || cfg_qpOutValCr.values[i] > MAX_QP, "Some entries cfg_qpOutValCr are out of valid range of -qpBdOffsetC to 63, inclusive."); -#if JVET_P0410_CHROMA_QP_MAPPING m_chromaQpMappingTableParams.m_deltaQpInValMinus1[1][i] = cfg_qpInValCr.values[i + 1] - cfg_qpInValCr.values[i] - 1; m_chromaQpMappingTableParams.m_deltaQpOutVal[1][i] = cfg_qpOutValCr.values[i + 1] - cfg_qpOutValCr.values[i]; -#else - m_chromaQpMappingTableParams.m_deltaQpInValMinus1[1][i] = (i == 0) ? cfg_qpInValCr.values[i] + qpBdOffsetC : cfg_qpInValCr.values[i] - cfg_qpInValCr.values[i - 1] - 1; - m_chromaQpMappingTableParams.m_deltaQpOutVal[1][i] = (i == 0) ? cfg_qpOutValCr.values[i] + qpBdOffsetC : cfg_qpOutValCr.values[i] - cfg_qpOutValCr.values[i - 1]; -#endif } m_chromaQpMappingTableParams.m_deltaQpInValMinus1[2].resize(cfg_qpInValCbCr.values.size()); m_chromaQpMappingTableParams.m_deltaQpOutVal[2].resize(cfg_qpOutValCbCr.values.size()); -#if JVET_P0410_CHROMA_QP_MAPPING m_chromaQpMappingTableParams.m_numPtsInCQPTableMinus1[2] = (cfg_qpOutValCbCr.values.size() > 1) ? (int)cfg_qpOutValCbCr.values.size() - 2 : 0; m_chromaQpMappingTableParams.m_qpTableStartMinus26[2] = (cfg_qpOutValCbCr.values.size() > 1) ? -26 + cfg_qpInValCbCr.values[0] : 0; CHECK(m_chromaQpMappingTableParams.m_qpTableStartMinus26[2] < -26 - qpBdOffsetC || m_chromaQpMappingTableParams.m_qpTableStartMinus26[2] > 36, "qpTableStartMinus26[2] is out of valid range of -26 -qpBdOffsetC to 36, inclusive.") CHECK(cfg_qpInValCbCr.values[0] != cfg_qpInValCbCr.values[0], "First qpInValCbCr value should be equal to first qpOutValCbCr value"); for (int i = 0; i < cfg_qpInValCbCr.values.size() - 1; i++) -#else - m_chromaQpMappingTableParams.m_numPtsInCQPTableMinus1[2] = (int)cfg_qpOutValCbCr.values.size()-1; - for (int i = 0; i < cfg_qpInValCbCr.values.size(); i++) -#endif { CHECK(cfg_qpInValCbCr.values[i] < -qpBdOffsetC || cfg_qpInValCbCr.values[i] > MAX_QP, "Some entries cfg_qpInValCbCr are out of valid range of -qpBdOffsetC to 63, inclusive."); CHECK(cfg_qpOutValCbCr.values[i] < -qpBdOffsetC || cfg_qpOutValCbCr.values[i] > MAX_QP, "Some entries cfg_qpOutValCbCr are out of valid range of -qpBdOffsetC to 63, inclusive."); -#if JVET_P0410_CHROMA_QP_MAPPING m_chromaQpMappingTableParams.m_deltaQpInValMinus1[2][i] = cfg_qpInValCbCr.values[i + 1] - cfg_qpInValCbCr.values[i] - 1; m_chromaQpMappingTableParams.m_deltaQpOutVal[2][i] = cfg_qpInValCbCr.values[i + 1] - cfg_qpInValCbCr.values[i]; -#else - m_chromaQpMappingTableParams.m_deltaQpInValMinus1[2][i] = (i == 0) ? cfg_qpInValCbCr.values[i] + qpBdOffsetC : cfg_qpInValCbCr.values[i] - cfg_qpInValCbCr.values[i - 1] - 1; - m_chromaQpMappingTableParams.m_deltaQpOutVal[2][i] = (i == 0) ? cfg_qpOutValCbCr.values[i] + qpBdOffsetC : cfg_qpOutValCbCr.values[i] - cfg_qpOutValCbCr.values[i - 1]; -#endif } } diff --git a/source/Lib/CommonLib/Slice.cpp b/source/Lib/CommonLib/Slice.cpp index e319d72945497d753efba4d254671013c1050b3a..c1a915755832ddff3a27b1eb16f86ac83ddaf640 100644 --- a/source/Lib/CommonLib/Slice.cpp +++ b/source/Lib/CommonLib/Slice.cpp @@ -1897,9 +1897,7 @@ void ChromaQpMappingTable::setParams(const ChromaQpMappingTableParams ¶ms, c { m_numPtsInCQPTableMinus1[i] = params.m_numPtsInCQPTableMinus1[i]; m_deltaQpInValMinus1[i] = params.m_deltaQpInValMinus1[i]; -#if JVET_P0410_CHROMA_QP_MAPPING m_qpTableStartMinus26[i] = params.m_qpTableStartMinus26[i]; -#endif m_deltaQpOutVal[i] = params.m_deltaQpOutVal[i]; } } @@ -1913,7 +1911,6 @@ void ChromaQpMappingTable::derivedChromaQPMappingTables() { const int qpBdOffsetC = m_qpBdOffset; const int numPtsInCQPTableMinus1 = getNumPtsInCQPTableMinus1(i); -#if JVET_P0410_CHROMA_QP_MAPPING std::vector<int> qpInVal(numPtsInCQPTableMinus1 + 2), qpOutVal(numPtsInCQPTableMinus1 + 2); qpInVal[0] = getQpTableStartMinus26(i) + 26; @@ -1923,17 +1920,6 @@ void ChromaQpMappingTable::derivedChromaQPMappingTables() qpInVal[j + 1] = qpInVal[j] + getDeltaQpInValMinus1(i, j) + 1; qpOutVal[j + 1] = qpOutVal[j] + getDeltaQpOutVal(i, j); } -#else - std::vector<int> qpInVal(numPtsInCQPTableMinus1 + 1), qpOutVal(numPtsInCQPTableMinus1 + 1); - - qpInVal[0] = -qpBdOffsetC + getDeltaQpInValMinus1(i, 0); - qpOutVal[0] = -qpBdOffsetC + getDeltaQpOutVal(i, 0); - for (int j = 1; j <= getNumPtsInCQPTableMinus1(i); j++) - { - qpInVal[j] = qpInVal[j - 1] + getDeltaQpInValMinus1(i, j) + 1; - qpOutVal[j] = qpOutVal[j - 1] + getDeltaQpOutVal(i, j); - } -#endif for (int j = 0; j <= getNumPtsInCQPTableMinus1(i); j++) { @@ -1946,33 +1932,16 @@ void ChromaQpMappingTable::derivedChromaQPMappingTables() { m_chromaQpMappingTables[i][k] = Clip3(-qpBdOffsetC, MAX_QP, m_chromaQpMappingTables[i][k + 1] - 1); } -#if JVET_P0410_CHROMA_QP_MAPPING for (int j = 0; j <= numPtsInCQPTableMinus1; j++) -#else - for (int j = 0; j < numPtsInCQPTableMinus1; j++) -#endif { -#if JVET_P0410_CHROMA_QP_MAPPING int sh = (getDeltaQpInValMinus1(i, j) + 1) >> 1; -#else - int sh = (getDeltaQpInValMinus1(i, j + 1) + 1) >> 1; -#endif for (int k = qpInVal[j] + 1, m = 1; k <= qpInVal[j + 1]; k++, m++) { -#if JVET_P0410_CHROMA_QP_MAPPING m_chromaQpMappingTables[i][k] = m_chromaQpMappingTables[i][qpInVal[j]] + ((qpOutVal[j + 1] - qpOutVal[j]) * m + sh) / (getDeltaQpInValMinus1(i, j) + 1); -#else - m_chromaQpMappingTables[i][k] = m_chromaQpMappingTables[i][qpInVal[j]] - + (getDeltaQpOutVal(i, j + 1) * m + sh) / (getDeltaQpInValMinus1(i, j + 1) + 1); -#endif } } -#if JVET_P0410_CHROMA_QP_MAPPING for (int k = qpInVal[numPtsInCQPTableMinus1 + 1] + 1; k <= MAX_QP; k++) -#else - for (int k = qpInVal[numPtsInCQPTableMinus1]+1; k <= MAX_QP; k++) -#endif { m_chromaQpMappingTables[i][k] = Clip3(-qpBdOffsetC, MAX_QP, m_chromaQpMappingTables[i][k - 1] + 1); } diff --git a/source/Lib/CommonLib/Slice.h b/source/Lib/CommonLib/Slice.h index 2ee732caa27b9f0d8b36943dc4370dd11ce995de..668b9b45e09c4e4e58ce6eeea8ef075f87e7e936 100644 --- a/source/Lib/CommonLib/Slice.h +++ b/source/Lib/CommonLib/Slice.h @@ -567,9 +567,7 @@ struct ChromaQpMappingTableParams { #if JVET_P0667_QP_OFFSET_TABLE_SIGNALING_JCCR int m_numQpTables; #endif -#if JVET_P0410_CHROMA_QP_MAPPING int m_qpTableStartMinus26[MAX_NUM_CQP_MAPPING_TABLES]; -#endif int m_numPtsInCQPTableMinus1[MAX_NUM_CQP_MAPPING_TABLES]; std::vector<int> m_deltaQpInValMinus1[MAX_NUM_CQP_MAPPING_TABLES]; std::vector<int> m_deltaQpOutVal[MAX_NUM_CQP_MAPPING_TABLES]; @@ -582,9 +580,7 @@ struct ChromaQpMappingTableParams { m_numQpTables = 1; #endif m_numPtsInCQPTableMinus1[0] = 0; -#if JVET_P0410_CHROMA_QP_MAPPING m_qpTableStartMinus26[0] = 0; -#endif m_deltaQpInValMinus1[0] = { 0 }; m_deltaQpOutVal[0] = { 0 }; } @@ -595,10 +591,8 @@ struct ChromaQpMappingTableParams { void setNumQpTables(int n) { m_numQpTables = n; } int getNumQpTables() const { return m_numQpTables; } #endif -#if JVET_P0410_CHROMA_QP_MAPPING void setQpTableStartMinus26(int tableIdx, int n) { m_qpTableStartMinus26[tableIdx] = n; } int getQpTableStartMinus26(int tableIdx) const { return m_qpTableStartMinus26[tableIdx]; } -#endif void setNumPtsInCQPTableMinus1(int tableIdx, int n) { m_numPtsInCQPTableMinus1[tableIdx] = n; } int getNumPtsInCQPTableMinus1(int tableIdx) const { return m_numPtsInCQPTableMinus1[tableIdx]; } void setDeltaQpInValMinus1(int tableIdx, std::vector<int> &inVals) { m_deltaQpInValMinus1[tableIdx] = inVals; } diff --git a/source/Lib/CommonLib/TypeDef.h b/source/Lib/CommonLib/TypeDef.h index 9bafd959b8684b8df108bd9a2e3ffbe427f5b771..0209d2f49bfda322ef2be7ab4fb207c7a45fcb98 100644 --- a/source/Lib/CommonLib/TypeDef.h +++ b/source/Lib/CommonLib/TypeDef.h @@ -75,7 +75,6 @@ -#define JVET_P0410_CHROMA_QP_MAPPING 1 // JVET-P0410: Chroma QP Mapping signalling #define JVET_P0366_NUT_CONSTRAINT_FLAGS 1 // JVET-P0366: Adding constraint flags for NAL unit types diff --git a/source/Lib/DecoderLib/VLCReader.cpp b/source/Lib/DecoderLib/VLCReader.cpp index b2898a0ff9d43dfe2b2458df8b44eb29e0574515..07a1b2eefd568668a95faf6ce6c1eacae61797fe 100644 --- a/source/Lib/DecoderLib/VLCReader.cpp +++ b/source/Lib/DecoderLib/VLCReader.cpp @@ -1321,10 +1321,8 @@ void HLSyntaxReader::parseSPS(SPS* pcSPS) for (int i = 0; i < (chromaQpMappingTableParams.getSameCQPTableForAllChromaFlag() ? 1 : 3); i++) #endif { -#if JVET_P0410_CHROMA_QP_MAPPING int32_t qpTableStart = 0; READ_SVLC(qpTableStart, "qp_table_starts_minus26"); chromaQpMappingTableParams.setQpTableStartMinus26(i, qpTableStart); -#endif READ_UVLC(uiCode, "num_points_in_qp_table_minus1"); chromaQpMappingTableParams.setNumPtsInCQPTableMinus1(i,uiCode); std::vector<int> deltaQpInValMinus1(chromaQpMappingTableParams.getNumPtsInCQPTableMinus1(i) + 1); std::vector<int> deltaQpOutVal(chromaQpMappingTableParams.getNumPtsInCQPTableMinus1(i) + 1); diff --git a/source/Lib/EncoderLib/VLCWriter.cpp b/source/Lib/EncoderLib/VLCWriter.cpp index 989872bd41e47e8f68fdee5e6ea53ef2dcd0dcc5..4509c77b3a60918266d1145d3ad350d5893f7da3 100644 --- a/source/Lib/EncoderLib/VLCWriter.cpp +++ b/source/Lib/EncoderLib/VLCWriter.cpp @@ -860,9 +860,7 @@ void HLSWriter::codeSPS( const SPS* pcSPS ) for (int i = 0; i < (chromaQpMappingTable.getSameCQPTableForAllChromaFlag() ? 1 : 3); i++) #endif { -#if JVET_P0410_CHROMA_QP_MAPPING WRITE_SVLC(chromaQpMappingTable.getQpTableStartMinus26(i), "qp_table_starts_minus26"); -#endif WRITE_UVLC(chromaQpMappingTable.getNumPtsInCQPTableMinus1(i), "num_points_in_qp_table_minus1"); for (int j = 0; j <= chromaQpMappingTable.getNumPtsInCQPTableMinus1(i); j++)