diff --git a/source/Lib/CommonLib/TypeDef.h b/source/Lib/CommonLib/TypeDef.h index 09557f5dce1bcf104da2cc49b9db5f61a3a41259..3046085ff050e28f64448a6fdd347bb6063582f9 100644 --- a/source/Lib/CommonLib/TypeDef.h +++ b/source/Lib/CommonLib/TypeDef.h @@ -73,7 +73,6 @@ -#define JVET_AD0056_NNPFC_INP_OUT_ORDER_IDC_CONSTRAINTS 1 #define JVET_AD0056_MOVE_NNPFC_INP_AND_OUT_ORDER_IDC 1 // Move nnpfc_inp_order_idc and nnpfc_out_order_idc, and gate the bit depth syntax elements diff --git a/source/Lib/DecoderLib/SEIread.cpp b/source/Lib/DecoderLib/SEIread.cpp index 6dae729221388229a5409e6079abf565cc195e78..286948caa92d2f940bd15d80ca94f8e6a88d71bc 100644 --- a/source/Lib/DecoderLib/SEIread.cpp +++ b/source/Lib/DecoderLib/SEIread.cpp @@ -2973,9 +2973,7 @@ void SEIReader::xParseSEINNPostFilterCharacteristics(SEINeuralNetworkPostFilterC sei.m_inpOrderIdc = val; CHECK(val > 3, "The value of nnpfc_inp_order_idc shall be in the range of 0 to 3"); #endif -#if JVET_AD0056_NNPFC_INP_OUT_ORDER_IDC_CONSTRAINTS CHECK(((sei.m_purpose & NNPC_PurposeType::CHROMA_UPSAMPLING) != 0) && sei.m_inpOrderIdc == 0, "When nnpfc_purpose & 0x02 is not equal to 0, nnpfc_inp_order_idc shall not be equal to 0."); -#endif #if JVET_AD0233_NNPFC_CHROMA_SAMPLE_LOC CHECK((chromaFormatIdc == ChromaFormat::_400) && (sei.m_inpOrderIdc != 0), "When ChromaFormatIdc is equal to 0, nnpfc_inp_order_idc shall be equal to 0"); @@ -3032,12 +3030,8 @@ void SEIReader::xParseSEINNPostFilterCharacteristics(SEINeuralNetworkPostFilterC #if JVET_AD0056_MOVE_NNPFC_INP_AND_OUT_ORDER_IDC sei_read_uvlc(pDecodedMessageOutputStream, val, "nnpfc_out_order_idc"); sei.m_outOrderIdc = val; -#if JVET_AD0056_NNPFC_INP_OUT_ORDER_IDC_CONSTRAINTS CHECK(((sei.m_purpose & NNPC_PurposeType::CHROMA_UPSAMPLING) != 0) && (sei.m_outOrderIdc == 0 || sei.m_outOrderIdc == 3), "When nnpfc_purpose & 0x02 is not equal to 0, nnpfc_out_order_idc shall not be equal to 0 or 3."); CHECK(((sei.m_purpose & NNPC_PurposeType::COLOURIZATION) != 0) && sei.m_outOrderIdc == 0, "When nnpfc_purpose & 0x20 is not equal to 0, nnpfc_out_order_idc shall not be equal to 0."); -#else - CHECK(((sei.m_purpose & NNPC_PurposeType::CHROMA_UPSAMPLING) != 0) && (sei.m_outOrderIdc == 3), "When nnpfc_purpose & 0x02 is not equal to 0, nnpfc_out_order_idc shall not be equal to 3.") -#endif #endif if (sei.m_outFormatIdc == 1) diff --git a/source/Lib/EncoderLib/SEIEncoder.cpp b/source/Lib/EncoderLib/SEIEncoder.cpp index ece1d6f98bd73d1e60bbc9cfadd1b9ca5336f310..91c442073b2561c262735d2b4e67ea5429ec588f 100644 --- a/source/Lib/EncoderLib/SEIEncoder.cpp +++ b/source/Lib/EncoderLib/SEIEncoder.cpp @@ -1456,9 +1456,7 @@ void SEIEncoder::initSEINeuralNetworkPostFilterCharacteristics(SEINeuralNetworkP } sei->m_inpOrderIdc = m_pcCfg->getNNPostFilterSEICharacteristicsInpOrderIdc(filterIdx); -#if JVET_AD0056_NNPFC_INP_OUT_ORDER_IDC_CONSTRAINTS CHECK((sei->m_purpose & NNPC_PurposeType::CHROMA_UPSAMPLING) != 0 && sei->m_inpOrderIdc == 0, "When nnpfc_purpose & 0x02 is not equal to 0, nnpfc_inp_order_idc shall not be equal to 0"); -#endif sei->m_auxInpIdc = m_pcCfg->getNNPostFilterSEICharacteristicsAuxInpIdc(filterIdx); #if !JVET_AD0056_MOVE_COLOUR_DESC_FLAG @@ -1501,10 +1499,8 @@ void SEIEncoder::initSEINeuralNetworkPostFilterCharacteristics(SEINeuralNetworkP } #endif sei->m_outOrderIdc = m_pcCfg->getNNPostFilterSEICharacteristicsOutOrderIdc(filterIdx); -#if JVET_AD0056_NNPFC_INP_OUT_ORDER_IDC_CONSTRAINTS CHECK((sei->m_purpose & NNPC_PurposeType::CHROMA_UPSAMPLING) != 0 && (sei->m_outOrderIdc == 0 || sei->m_outOrderIdc == 3), "When nnpfc_purpose & 0x02 is not equal to 0, nnpfc_out_order_idc shall not be equal to 0 or 3"); CHECK((sei->m_purpose & NNPC_PurposeType::COLOURIZATION) != 0 && sei->m_outOrderIdc == 0, "When nnpfc_purpose & 0x20 is not equal to 0, nnpfc_out_order_idc shall not be equal to 0"); -#endif #if JVET_AD0233_NNPFC_CHROMA_SAMPLE_LOC sei->m_chromaLocInfoPresentFlag = m_pcCfg->getNNPostFilterSEICharacteristicsChromaLocInfoPresentFlag(filterIdx); if(sei->m_chromaLocInfoPresentFlag)