diff --git a/source/App/EncoderApp/EncAppCfg.cpp b/source/App/EncoderApp/EncAppCfg.cpp index 8de0b3b5ec0dfc2362f885788a6938c5f01924b5..656f6859d2a2414c6a0c931d70a4c630198a4383 100644 --- a/source/App/EncoderApp/EncAppCfg.cpp +++ b/source/App/EncoderApp/EncAppCfg.cpp @@ -1942,20 +1942,14 @@ bool EncAppCfg::parseCfg( int argc, char* argv[] ) } else // m_profile == Profile::NONE { -#if JVET_S0094_CHROMAFORMAT_BITDEPTH_CONSTRAINT m_bitDepthConstraint = 16; // max value - unconstrained. -#else - m_bitDepthConstraint = 8+15; // max value - unconstrained. -#endif } } -#if JVET_S0094_CHROMAFORMAT_BITDEPTH_CONSTRAINT CHECK(m_bitDepthConstraint < m_internalBitDepth[CHANNEL_TYPE_LUMA], "MaxBitDepthConstraint setting does not allow the specified luma bit depth to be coded."); CHECK(m_bitDepthConstraint < m_internalBitDepth[CHANNEL_TYPE_CHROMA], "MaxBitDepthConstraint setting does not allow the specified chroma bit depth to be coded."); CHECK(m_chromaFormatConstraint < m_chromaFormatIDC, "MaxChromaFormatConstraint setting does not allow the specified chroma format to be coded."); CHECK(m_chromaFormatConstraint >= NUM_CHROMA_FORMAT, "Bad value given for MaxChromaFormatConstraint setting.") CHECK(m_bitDepthConstraint < 8 || m_bitDepthConstraint>16, "MaxBitDepthConstraint setting must be in the range 8 to 16 (inclusive)"); -#endif } diff --git a/source/Lib/CommonLib/Slice.h b/source/Lib/CommonLib/Slice.h index 99f3ddbe088ab8faddb901e3ee0e975da70cb3e9..ed1965047368c93e08a23d8e246563641f3ba04d 100644 --- a/source/Lib/CommonLib/Slice.h +++ b/source/Lib/CommonLib/Slice.h @@ -341,13 +341,8 @@ public: , m_frameOnlyConstraintFlag (false) #endif , m_intraOnlyConstraintFlag (false) -#if JVET_S0094_CHROMAFORMAT_BITDEPTH_CONSTRAINT , m_maxBitDepthConstraintIdc ( 16) , m_maxChromaFormatConstraintIdc(CHROMA_444) -#else - , m_maxBitDepthConstraintIdc ( 0) - , m_maxChromaFormatConstraintIdc(CHROMA_420) -#endif , m_onePictureOnlyConstraintFlag (false) , m_lowerBitRateConstraintFlag (false ) #if !JVET_S0138_GCI_PTL diff --git a/source/Lib/CommonLib/TypeDef.h b/source/Lib/CommonLib/TypeDef.h index 4a6658a5de38ca749df4d5edeb163fbfd5174e3f..09294bb9f5b48b4ec884082fe51bb578e69dd528 100644 --- a/source/Lib/CommonLib/TypeDef.h +++ b/source/Lib/CommonLib/TypeDef.h @@ -85,7 +85,6 @@ -#define JVET_S0094_CHROMAFORMAT_BITDEPTH_CONSTRAINT 1 // JVET-S0094: 0 for constraint flags for chroma format and bit depth mean unconstrained, by coding these constraints as subtractive #define JVET_S0132_HLS_REORDER 1 // Rearrange syntax elements in SPS and PPS diff --git a/source/Lib/DecoderLib/VLCReader.cpp b/source/Lib/DecoderLib/VLCReader.cpp index 7f1d2976f18840e4e5cbd46a64d693d32a29f03b..8a02376c8f0e13205a6f81dc886ac5a2fbdfa651 100644 --- a/source/Lib/DecoderLib/VLCReader.cpp +++ b/source/Lib/DecoderLib/VLCReader.cpp @@ -4683,14 +4683,9 @@ void HLSyntaxReader::parseConstraintInfo(ConstraintInfo *cinfo) READ_FLAG(symbol, "general_one_picture_only_constraint_flag" ); cinfo->setOnePictureOnlyConstraintFlag(symbol ? true : false); READ_FLAG(symbol, "intra_only_constraint_flag" ); cinfo->setIntraOnlyConstraintFlag(symbol ? true : false); -#if JVET_S0094_CHROMAFORMAT_BITDEPTH_CONSTRAINT READ_CODE(4, symbol, "gci_sixteen_minus_max_bitdepth_constraint_idc" ); cinfo->setMaxBitDepthConstraintIdc(symbol>8 ? 16 : (16-symbol)); CHECK(symbol>8, "gci_sixteen_minus_max_bitdepth_constraint_idc shall be in the range 0 to 8, inclusive"); READ_CODE(2, symbol, "gci_three_minus_max_chroma_format_constraint_idc" ); cinfo->setMaxChromaFormatConstraintIdc((ChromaFormat)(3-symbol)); -#else - READ_CODE(4, symbol, "max_bitdepth_constraint_idc" ); cinfo->setMaxBitDepthConstraintIdc(symbol); - READ_CODE(2, symbol, "max_chroma_format_constraint_idc" ); cinfo->setMaxChromaFormatConstraintIdc((ChromaFormat)symbol); -#endif #if !JVET_S0138_GCI_PTL READ_FLAG(symbol, "single_layer_constraint_flag"); cinfo->setSingleLayerConstraintFlag(symbol ? true : false); #endif diff --git a/source/Lib/EncoderLib/VLCWriter.cpp b/source/Lib/EncoderLib/VLCWriter.cpp index b1551ff2d07172d2217dc5ac4f3900e921b8ad81..17b8311694464c99cfd09202e446ad37cb52ef9f 100644 --- a/source/Lib/EncoderLib/VLCWriter.cpp +++ b/source/Lib/EncoderLib/VLCWriter.cpp @@ -2762,13 +2762,8 @@ void HLSWriter::codeConstraintInfo ( const ConstraintInfo* cinfo ) WRITE_FLAG(cinfo->getOnePictureOnlyConstraintFlag(), "general_one_picture_only_constraint_flag" ); WRITE_FLAG(cinfo->getIntraOnlyConstraintFlag(), "intra_only_constraint_flag" ); -#if JVET_S0094_CHROMAFORMAT_BITDEPTH_CONSTRAINT WRITE_CODE(16-cinfo->getMaxBitDepthConstraintIdc(), 4, "gci_sixteen_minus_max_bitdepth_constraint_idc" ); WRITE_CODE(3-cinfo->getMaxChromaFormatConstraintIdc(), 2, "gci_three_minus_max_chroma_format_constraint_idc" ); -#else - WRITE_CODE(cinfo->getMaxBitDepthConstraintIdc(), 4, "max_bitdepth_constraint_idc" ); - WRITE_CODE(cinfo->getMaxChromaFormatConstraintIdc(), 2, "max_chroma_format_constraint_idc" ); -#endif #if !JVET_S0138_GCI_PTL WRITE_FLAG(cinfo->getSingleLayerConstraintFlag(), "single_layer_constraint_flag"); #endif