diff --git a/source/Lib/CommonLib/TypeDef.h b/source/Lib/CommonLib/TypeDef.h index 358bd2f9eb0401ad1268a36b966076aec2538572..575d36122b67355d6db26dc071e40c09f5d14936 100644 --- a/source/Lib/CommonLib/TypeDef.h +++ b/source/Lib/CommonLib/TypeDef.h @@ -104,7 +104,6 @@ -#define JVET_R0186_CLEANUP 1 // JVET-R0186 aspect 1: Signal the pps_no_pic_partition_flag ahead in the PPS. #define JVET_R0225_SEPERATE_FLAGS_ALF_CHROMA 1 // Use two separate flags (one for Cb, one for Cr) to replace ph_alf_chroma_idc in PH and sh_alf_chroma_idc in SH diff --git a/source/Lib/DecoderLib/VLCReader.cpp b/source/Lib/DecoderLib/VLCReader.cpp index aa8600b4cb918b44cb4d1aa72ca2b5819c85947b..071ca845a9523166690e8ea3d3557024a0a13511 100644 --- a/source/Lib/DecoderLib/VLCReader.cpp +++ b/source/Lib/DecoderLib/VLCReader.cpp @@ -481,13 +481,10 @@ void HLSyntaxReader::parsePPS( PPS* pcPPS ) READ_FLAG( uiCode, "output_flag_present_flag" ); pcPPS->setOutputFlagPresentFlag( uiCode==1 ); -#if JVET_R0186_CLEANUP READ_FLAG( uiCode, "pps_no_pic_partition_flag"); pcPPS->setNoPicPartitionFlag(uiCode == 1); -#endif READ_FLAG( uiCode, "subpic_id_mapping_in_pps_flag" ); pcPPS->setSubPicIdMappingInPpsFlag( uiCode != 0 ); if( pcPPS->getSubPicIdMappingInPpsFlag() ) { -#if JVET_R0186_CLEANUP if( !pcPPS->getNoPicPartitionFlag() ) { READ_UVLC(uiCode, "pps_num_subpics_minus1"); pcPPS->setNumSubPics(uiCode + 1); @@ -496,9 +493,6 @@ void HLSyntaxReader::parsePPS( PPS* pcPPS ) { pcPPS->setNumSubPics(1); } -#else - READ_UVLC( uiCode, "pps_num_subpics_minus1" ); pcPPS->setNumSubPics( uiCode + 1 ); -#endif CHECK( uiCode > MAX_NUM_SUB_PICS-1, "Number of sub-pictures exceeds limit"); READ_UVLC( uiCode, "pps_subpic_id_len_minus1" ); pcPPS->setSubPicIdLen( uiCode + 1 ); @@ -510,9 +504,6 @@ void HLSyntaxReader::parsePPS( PPS* pcPPS ) READ_CODE( pcPPS->getSubPicIdLen( ), uiCode, "pps_subpic_id[i]" ); pcPPS->setSubPicId( picIdx, uiCode ); } } -#if !JVET_R0186_CLEANUP - READ_FLAG( uiCode, "no_pic_partition_flag" ); pcPPS->setNoPicPartitionFlag( uiCode == 1 ); -#endif if(!pcPPS->getNoPicPartitionFlag()) { int colIdx, rowIdx; diff --git a/source/Lib/EncoderLib/VLCWriter.cpp b/source/Lib/EncoderLib/VLCWriter.cpp index 94ff6ad13405e6c52c6ac1c04c87769b65143b83..e127ef0f5376885c1dc17a7eeb621f8abf1abc06 100644 --- a/source/Lib/EncoderLib/VLCWriter.cpp +++ b/source/Lib/EncoderLib/VLCWriter.cpp @@ -295,21 +295,15 @@ void HLSWriter::codePPS( const PPS* pcPPS ) } WRITE_FLAG( pcPPS->getOutputFlagPresentFlag() ? 1 : 0, "output_flag_present_flag" ); -#if JVET_R0186_CLEANUP WRITE_FLAG( pcPPS->getNoPicPartitionFlag() ? 1 : 0, "pps_no_pic_partition_flag" ); -#endif WRITE_FLAG( pcPPS->getSubPicIdMappingInPpsFlag() ? 1 : 0, "subpic_id_mapping_in_pps_flag" ); if( pcPPS->getSubPicIdMappingInPpsFlag() ) { CHECK(pcPPS->getNumSubPics() < 1, "PPS: NumSubPics cannot be less than 1"); -#if JVET_R0186_CLEANUP if( !pcPPS->getNoPicPartitionFlag() ) { WRITE_UVLC(pcPPS->getNumSubPics() - 1, "pps_num_subpics_minus1"); } -#else - WRITE_UVLC( pcPPS->getNumSubPics() - 1, "pps_num_subpics_minus1" ); -#endif CHECK(pcPPS->getSubPicIdLen() < 1, "PPS: SubPicIdLen cannot be less than 1"); WRITE_UVLC( pcPPS->getSubPicIdLen() - 1, "pps_subpic_id_len_minus1" ); @@ -319,9 +313,6 @@ void HLSWriter::codePPS( const PPS* pcPPS ) WRITE_CODE( pcPPS->getSubPicId(picIdx), pcPPS->getSubPicIdLen( ), "pps_subpic_id[i]" ); } } -#if !JVET_R0186_CLEANUP - WRITE_FLAG( pcPPS->getNoPicPartitionFlag( ) ? 1 : 0, "no_pic_partition_flag" ); -#endif if( !pcPPS->getNoPicPartitionFlag() ) { int colIdx, rowIdx;