diff --git a/source/App/EncoderApp/EncAppCfg.cpp b/source/App/EncoderApp/EncAppCfg.cpp index 53f5fe792adf31e6414adf399c52be678e4c5822..24ec767c7fa4f25b6d6afd3c20c3cf2c37a3ddef 100644 --- a/source/App/EncoderApp/EncAppCfg.cpp +++ b/source/App/EncoderApp/EncAppCfg.cpp @@ -3726,13 +3726,13 @@ void EncAppCfg::xPrintParameter() { msg( VERBOSE, "RPR:%d", 0 ); } - -#if EXTENSION_360_VIDEO - m_ext360.outputConfigurationSummary(); -#endif #if JVET_O0549_ENCODER_ONLY_FILTER msg(VERBOSE, "TemporalFilter:%d ", m_gopBasedTemporalFilterEnabled); #endif +#if EXTENSION_360_VIDEO + m_ext360.outputConfigurationSummary(); +#endif + msg( VERBOSE, "\n\n"); msg( NOTICE, "\n"); diff --git a/source/Lib/CommonLib/AdaptiveLoopFilter.cpp b/source/Lib/CommonLib/AdaptiveLoopFilter.cpp index f82eefedd0eb3ad5ed99c6721c1dabcc4f0a4901..912fb32ab20c827e246a41ed70473c35906ada27 100644 --- a/source/Lib/CommonLib/AdaptiveLoopFilter.cpp +++ b/source/Lib/CommonLib/AdaptiveLoopFilter.cpp @@ -1171,55 +1171,53 @@ void AdaptiveLoopFilter::filterBlk(AlfClassifier **classifier, const PelUnitBuf clip = fClipSet + cl.classIdx * MAX_NUM_ALF_LUMA_COEFF; } - if( filtType == ALF_FILTER_7 ) { if( transposeIdx == 1 ) { - filterCoeff = { { coef[9], coef[4], coef[10], coef[8], coef[1], coef[5], coef[11], coef[7], coef[3], coef[0], coef[2], coef[6], coef[12] }}; - filterClipp = { { clip[9], clip[4], clip[10], clip[8], clip[1], clip[5], clip[11], clip[7], clip[3], clip[0], clip[2], clip[6], clip[12] }}; + filterCoeff = { coef[9], coef[4], coef[10], coef[8], coef[1], coef[5], coef[11], coef[7], coef[3], coef[0], coef[2], coef[6], coef[12] }; + filterClipp = { clip[9], clip[4], clip[10], clip[8], clip[1], clip[5], clip[11], clip[7], clip[3], clip[0], clip[2], clip[6], clip[12] }; } else if( transposeIdx == 2 ) { - filterCoeff = { { coef[0], coef[3], coef[2], coef[1], coef[8], coef[7], coef[6], coef[5], coef[4], coef[9], coef[10], coef[11], coef[12] }}; - filterClipp = { { clip[0], clip[3], clip[2], clip[1], clip[8], clip[7], clip[6], clip[5], clip[4], clip[9], clip[10], clip[11], clip[12] }}; + filterCoeff = { coef[0], coef[3], coef[2], coef[1], coef[8], coef[7], coef[6], coef[5], coef[4], coef[9], coef[10], coef[11], coef[12] }; + filterClipp = { clip[0], clip[3], clip[2], clip[1], clip[8], clip[7], clip[6], clip[5], clip[4], clip[9], clip[10], clip[11], clip[12] }; } else if( transposeIdx == 3 ) { - filterCoeff = { { coef[9], coef[8], coef[10], coef[4], coef[3], coef[7], coef[11], coef[5], coef[1], coef[0], coef[2], coef[6], coef[12] }}; - filterClipp = { { clip[9], clip[8], clip[10], clip[4], clip[3], clip[7], clip[11], clip[5], clip[1], clip[0], clip[2], clip[6], clip[12] }}; + filterCoeff = { coef[9], coef[8], coef[10], coef[4], coef[3], coef[7], coef[11], coef[5], coef[1], coef[0], coef[2], coef[6], coef[12] }; + filterClipp = { clip[9], clip[8], clip[10], clip[4], clip[3], clip[7], clip[11], clip[5], clip[1], clip[0], clip[2], clip[6], clip[12] }; } else { - filterCoeff = { { coef[0], coef[1], coef[2], coef[3], coef[4], coef[5], coef[6], coef[7], coef[8], coef[9], coef[10], coef[11], coef[12] }}; - filterClipp = { { clip[0], clip[1], clip[2], clip[3], clip[4], clip[5], clip[6], clip[7], clip[8], clip[9], clip[10], clip[11], clip[12] }}; + filterCoeff = { coef[0], coef[1], coef[2], coef[3], coef[4], coef[5], coef[6], coef[7], coef[8], coef[9], coef[10], coef[11], coef[12] }; + filterClipp = { clip[0], clip[1], clip[2], clip[3], clip[4], clip[5], clip[6], clip[7], clip[8], clip[9], clip[10], clip[11], clip[12] }; } } else { if( transposeIdx == 1 ) { - filterCoeff = { { coef[4], coef[1], coef[5], coef[3], coef[0], coef[2], coef[6] }}; - filterClipp = { { clip[4], clip[1], clip[5], clip[3], clip[0], clip[2], clip[6] }}; + filterCoeff = { coef[4], coef[1], coef[5], coef[3], coef[0], coef[2], coef[6] }; + filterClipp = { clip[4], clip[1], clip[5], clip[3], clip[0], clip[2], clip[6] }; } else if( transposeIdx == 2 ) { - filterCoeff = { { coef[0], coef[3], coef[2], coef[1], coef[4], coef[5], coef[6] }}; - filterClipp = { { clip[0], clip[3], clip[2], clip[1], clip[4], clip[5], clip[6] }}; + filterCoeff = { coef[0], coef[3], coef[2], coef[1], coef[4], coef[5], coef[6] }; + filterClipp = { clip[0], clip[3], clip[2], clip[1], clip[4], clip[5], clip[6] }; } else if( transposeIdx == 3 ) { - filterCoeff = { { coef[4], coef[3], coef[5], coef[1], coef[0], coef[2], coef[6] }}; - filterClipp = { { clip[4], clip[3], clip[5], clip[1], clip[0], clip[2], clip[6] }}; + filterCoeff = { coef[4], coef[3], coef[5], coef[1], coef[0], coef[2], coef[6] }; + filterClipp = { clip[4], clip[3], clip[5], clip[1], clip[0], clip[2], clip[6] }; } else { - filterCoeff = { { coef[0], coef[1], coef[2], coef[3], coef[4], coef[5], coef[6] }}; - filterClipp = { { clip[0], clip[1], clip[2], clip[3], clip[4], clip[5], clip[6] }}; + filterCoeff = { coef[0], coef[1], coef[2], coef[3], coef[4], coef[5], coef[6] }; + filterClipp = { clip[0], clip[1], clip[2], clip[3], clip[4], clip[5], clip[6] }; } } - for( int ii = 0; ii < clsSizeY; ii++ ) { pImg0 = pImgYPad0 + j + ii * srcStride; @@ -1393,6 +1391,3 @@ void AdaptiveLoopFilter::filterBlk(AlfClassifier **classifier, const PelUnitBuf pImgYPad6 += srcStride2; } } - - - diff --git a/source/Lib/CommonLib/TrQuant.cpp b/source/Lib/CommonLib/TrQuant.cpp index 5e65217b83d53e77f6c9286ce02e6caafc82a21b..11ecdde1833448b1756b3609ba55a0592e4680f7 100644 --- a/source/Lib/CommonLib/TrQuant.cpp +++ b/source/Lib/CommonLib/TrQuant.cpp @@ -818,14 +818,14 @@ void TrQuant::xT( const TransformUnit &tu, const ComponentID &compID, const CPel { const int shift = ((floorLog2(width )) + bitDepth + TRANSFORM_MATRIX_SHIFT) - maxLog2TrDynamicRange + COM16_C806_TRANS_PREC; CHECK( shift < 0, "Negative shift" ); - // CHECKD( ( transformWidthIndex < 0 ), "There is a problem with the width." ); + CHECKD( ( transformWidthIndex < 0 ), "There is a problem with the width." ); fastFwdTrans[trTypeHor][transformWidthIndex]( block, dstCoeff.buf, shift, 1, 0, skipWidth ); } else //if (iWidth == 1) //1-D vertical transform { int shift = ( ( floorLog2(height) ) + bitDepth + TRANSFORM_MATRIX_SHIFT ) - maxLog2TrDynamicRange + COM16_C806_TRANS_PREC; CHECK( shift < 0, "Negative shift" ); - // CHECKD( ( transformHeightIndex < 0 ), "There is a problem with the height." ); + CHECKD( ( transformHeightIndex < 0 ), "There is a problem with the height." ); fastFwdTrans[trTypeVer][transformHeightIndex]( block, dstCoeff.buf, shift, 1, 0, skipHeight ); } } @@ -879,14 +879,14 @@ void TrQuant::xIT( const TransformUnit &tu, const ComponentID &compID, const CCo { int shift = ( TRANSFORM_MATRIX_SHIFT + maxLog2TrDynamicRange - 1 ) - bitDepth + COM16_C806_TRANS_PREC; CHECK( shift < 0, "Negative shift" ); - // CHECK( ( transformHeightIndex < 0 ), "There is a problem with the height." ); + CHECK( ( transformHeightIndex < 0 ), "There is a problem with the height." ); fastInvTrans[trTypeVer][transformHeightIndex]( pCoeff.buf, block, shift + 1, 1, 0, skipHeight, clipMinimum, clipMaximum ); } else //if(iHeight == 1) //1-D horizontal transform { const int shift = ( TRANSFORM_MATRIX_SHIFT + maxLog2TrDynamicRange - 1 ) - bitDepth + COM16_C806_TRANS_PREC; CHECK( shift < 0, "Negative shift" ); - // CHECK( ( transformWidthIndex < 0 ), "There is a problem with the width." ); + CHECK( ( transformWidthIndex < 0 ), "There is a problem with the width." ); fastInvTrans[trTypeHor][transformWidthIndex]( pCoeff.buf, block, shift + 1, 1, 0, skipWidth, clipMinimum, clipMaximum ); } diff --git a/source/Lib/EncoderLib/EncCu.cpp b/source/Lib/EncoderLib/EncCu.cpp index 07416a712fc82811baee7e77cf94a1b4e00045a3..d315172bb131403f6d6c149d50ccb9a9583ac545 100644 --- a/source/Lib/EncoderLib/EncCu.cpp +++ b/source/Lib/EncoderLib/EncCu.cpp @@ -2619,7 +2619,7 @@ void EncCu::xCheckRDCostMerge2Nx2N( CodingStructure *&tempCS, CodingStructure *& pu.mhIntraFlag = true; pu.regularMergeFlag = false; pu.intraDir[0] = PLANAR_IDX; - // CHECK(pu.intraDir[0]<0 || pu.intraDir[0]>(NUM_LUMA_MODE - 1), "out of intra mode"); + CHECK(pu.intraDir[0]<0 || pu.intraDir[0]>(NUM_LUMA_MODE - 1), "out of intra mode"); pu.intraDir[1] = DM_CHROMA_IDX; } else if (RdModeList[uiMrgHADIdx].isMMVD) diff --git a/source/Lib/EncoderLib/IntraSearch.h b/source/Lib/EncoderLib/IntraSearch.h index a3ee1da27dae2b421b4067b2ee4e9a6d4737a9f9..664d0b39229c5737737b91b8db9b9043131f00fb 100644 --- a/source/Lib/EncoderLib/IntraSearch.h +++ b/source/Lib/EncoderLib/IntraSearch.h @@ -262,7 +262,7 @@ private: int getNumCompletedSubParts(ISPType splitType, int iModeIdx) { const unsigned st = splitType - 1; - // CHECK(st < 0 || st > 1, "The split type is invalid!"); + CHECK(st < 0 || st > 1, "The split type is invalid!"); CHECK(iModeIdx < 0 || iModeIdx >(NUM_LUMA_MODE - 1), "The modeIdx is invalid"); return modeHasBeenTested[iModeIdx][st] ? intraMode[iModeIdx][st].numCompSubParts : -1; } diff --git a/source/Lib/Utilities/program_options_lite.h b/source/Lib/Utilities/program_options_lite.h index 696a6cdb1e8f5aebe38af53e0aa10052f67a6c98..dfd082cb73f9ca67f58d04a6ce1a2fd97b51910c 100644 --- a/source/Lib/Utilities/program_options_lite.h +++ b/source/Lib/Utilities/program_options_lite.h @@ -114,7 +114,7 @@ namespace df template<typename T> struct Option : public OptionBase { - Option(const std::string& name, T& storage, T default_val, const std::string& desc) // qqqqq + Option(const std::string& name, T& storage, T default_val, const std::string& desc) : OptionBase(name, desc), opt_storage(storage), opt_default_val(default_val) {}