From 5c54891da97e67bc082b54ce410e643bec92ffa8 Mon Sep 17 00:00:00 2001
From: Nan Hu <nanh@qti.qualcomm.com>
Date: Wed, 28 Feb 2024 09:45:38 -0800
Subject: [PATCH] define i in the for loop, change /= factor into *= factor
---
source/Lib/EncoderLib/EncAdaptiveLoopFilter.cpp | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/source/Lib/EncoderLib/EncAdaptiveLoopFilter.cpp b/source/Lib/EncoderLib/EncAdaptiveLoopFilter.cpp
index e4a0d55d4..7ed3378a2 100644
--- a/source/Lib/EncoderLib/EncAdaptiveLoopFilter.cpp
+++ b/source/Lib/EncoderLib/EncAdaptiveLoopFilter.cpp
@@ -252,7 +252,7 @@ double AlfCovariance::optimizeFilter(const AlfFilterShape& alfShape, AlfClipIdx*
void AlfCovariance::calcInitErrorForCoeffs(double *cAc, double *cA, double *bc, const AlfClipIdx *clip, const AlfCoeff *coeff, const int numCoeff, const int fractionalBits ) const
{
- double factor = (double) (1 << fractionalBits );
+ const double factor = 1.0 / (1 << fractionalBits);
*cAc = 0;
*bc = 0;
@@ -269,20 +269,18 @@ void AlfCovariance::calcInitErrorForCoeffs(double *cAc, double *cA, double *bc,
*bc += 2*coeff[i] * y(clip[i],i);
}
- *cAc /= factor * factor;
+ *cAc *= factor * factor;
for (ptrdiff_t i = 0; i < numCoeff; i++) // diagonal
{
- cA[i] /= factor;
+ cA[i] *= factor;
}
- *bc /= factor;
+ *bc *= factor;
}
void AlfCovariance::updateErrorForCoeffsDelta(double *cAc, double *cA, double *bc, const AlfClipIdx *clip, const AlfCoeff *coeff, const int numCoeff, double cDelta, int modInd ) const
{
- int i;
-
*cAc = (*cAc) + cDelta * cA[modInd] + cDelta * cDelta * E( clip[modInd], clip[modInd], modInd, modInd);
- for (i = 0; i < numCoeff; i++) {
+ for (int i = 0; i < numCoeff; i++) {
cA[i] += 2 * cDelta * E( clip[modInd], clip[i], modInd, i);
}
(*bc) = (*bc) + 2 * y(clip[modInd], modInd) * cDelta;
--
GitLab