Skip to content

Fix: RPR encoder crash when JVET_AH0314_LIC_INHERITANCE_FOR_MRG=1

Chun-Chi Chen requested to merge chunchic/ecm-4:ECM14_FixRprCrash-for-LicInherit into master

Below is the configuration to reproducing the RPR crash. bin/EncoderAppStaticd -c cfg/encoder_lowdelay_ecm.cfg -c cfg/per-sequence/BQSquare.cfg -i .../BQSquare_416x240_60fps_8bit_420.yuv --QP=37 --SEIDecodedPictureHash=1 --RPR=1 --RPRFunctionalityTesting=1 -o enc.yuv -b str.bin

The crash occurs in InterPrediction::adjustMergeCandidates and mvpMergeCandCtx.numCandToTestEnc != mvpMergeCandCtx.numValidMergeCand. Assuming mvpMergeCandCtx.numCandToTestEnc = 2, the first two candidates are never been pushed into rdCandList and thus their groupId remains -1 whic is wrong, resulting in the crash at the line "const MergeCtx& srcMrgCtx = *mrgList[rdCandGrpList[uiMergeCand]];" in InterPrediction::updateCandInMultiCandidateGroups

Merge request reports