JVET-AH0099: RPR 1.5x

This merge request includes enabling RPR with a scaling ratio of 1.5x in NNVC software.

can you clarify how to use rpr x1.5 (full encoder command line)? ... and the difference with nnsr usage. I am not sure to understand why we need special code for nnsr. Especially we have options related to nnsr in nn-based (in nnsr_classAxx.cfg) but they are actually used for rpr...

Why don t we have:

• no rpr nor nnsr: ratio=1
• rpr (1.5 or 2 depending on the cfg): ratio 1.5 or 2. Need to specify ratio (as in rpr/scalexx.cfg + add the qp options (maybe renaming it?).
• nnsr: same as above but also specify nn-based/nnsr.cfg + maybe different qps?

Hi, Franck, Thank you for your questions.

1. The encoder command line for the usage of RPR x1.5 is: -c cfg/nn-based/nnsr.cfg --FractionNumFrames=1.0 --NnsrModelName=default_rpr --ScalingRatioHor=1.5 --ScalingRatioVer=1.5 -c cfg/nn-based/nnsr_classA1_1.5x.cfg (or nnsr_classA2_1.5x.cfg)
2. In current implementation of NNVC, both nnsr and RPR use the configuration specified in cfg/nn-based/nnsr.cfg. The QP offsets for 2x are specified in nnsr_classA1.cfg and nnsr_classA2.cfg, while for 1.5x are in nnsr_classA1_1.5x.cfg and nnsr_classA2_1.5x.cfg.
3. [Q] Why don't we have "no rpr nor nnsr: ratio=1?" [A] We have "ratio=1" when neither m_rprEnabledFlag nor m_nnsrOption is true.

why dont we put the ScalingRatioxxx and other needed parameters in the cfg/nn-based/nnsr_classAxxx.cfg ? then we can have a cfg/nn-based/nnsr.cfg a cfg/nn-based/rpr.cfg (as our rpr is different from the legacy rpr). It makes clear that everything is common except the name of the model.

Hi, Franck, Thank you for your suggestion. I think it's a good way to make things clear. We will update the cfg/nn-based/nnsr_classAxxx.cfg.

thx!

added 1 commit

• 2504d5c7 - update version

Compare with previous version

Hi, Franck, We has submitted a new merge request !210 (merged). The command line for the usage of RPR:

1. rpr 1.5x: -c cfg/nn-based/nnsr/rpr.cfg -c cfg/nn-based/nnsr/nnsr_classA1_1.5x.cfg (or nnsr_classA2_1.5x.cfg)

2. rpr 2x: -c cfg/nn-based/nnsr/rpr.cfg -c cfg/nn-based/nnsr/nnsr_classA1_2.0x.cfg (or nnsr_classA2_2.0x.cfg)

added 6 commits

• 2504d5c7...542ab7fe - 4 commits from branch jvet-ahg-nnvc:VTM-11.0_nnvc
• 66d6df2d - JVET-AH0099_RPR1.5x
• d7ea781e - update version

Compare with previous version

added 1 commit

• 1c04e195 - Fix control for nnsr

Compare with previous version

thanks a lot, looks clean now. merging

merged

mentioned in commit f56b868a