Picture Timing SEI is intentionally not used in parsing of frame field information SEI.

In the existing code retrieving the picture timing SEI from HRD could return a nullptr, when the SEI has
not arrived yet. The pointer is dereferenced without checking and passed into frame field info SEI parsing
function and used for a consistency check.

This refactoring moves the check after parsing of all SEI messages.

Karsten Suehring authored 4 years ago and Frank Bossen committed 4 years ago

   - See ticket #1406

Updated the check to be made for the `pcRefPic` instead of `m_pcPic`. Also solved the issue with crashing at the decoder side.

   - Add checks on value of dph_sei_single_component_flag.

   - Add macro to enable/disable this change.

   - See ticket #1405

   - See ticket #1404

   - See ticket #1299

Add a constraint on an ILRP being either an IRAP picture or having TemporalId less than or equal to Max (0, vps_max_tid_il_ref_pics_plus1[ refPicVpsLayerId ] - 1 )

Revert "JVET-R0046-aspect2: Add a constraint on an ILRP being either an IRAP picture or having TemporalId less than or equal to Max( 0, vps_max_tid_il_ref_pics_plus1[ refPicVpsLayerId ] − 1 )"

This reverts commit e803f490.

This reverts commit 764b4ae6.

JVET-R0046-aspect2: Add a constraint on an ILRP being either an IRAP picture or having TemporalId less than or equal to Max( 0, vps_max_tid_il_ref_pics_plus1[ refPicVpsLayerId ] − 1 )

In case there is no reordering in the GOP, leading pictures cannot occur withing the VTM encoding process (e.g. LDB/P configurations).

GCI is not initialized in VPS or DCI. This leads to sending lots of flags with "no constraint" values. Setting gci_present_flag to 0 has the same semantic meaning.

This results in setting max_tid_ref_present_flag to 0 and not sending the syntax element.

The previous default of -1 would try to send (uint32_t)-1 in three bits.