Philip Cowan authored 5 years ago and Karsten Suehring committed 5 years ago

Implement N0124, proposal 1, an inference rule for when single_tile_per_tile_group_flag is not present.

The change fixes the problem of encoder/decoder mismatches by removing
a no longer correct condition for sign hiding in Quant::quant(..).

As reported in ticket #291, when sig_flag is inferred, the variables
m_tmplCpDiag and m_tmplCpSum1 are not set correctly, but used for
deriving the contexts for par_glag, gt1_flag, and gt3_flag.

The provided modification fixes this issue by calling cctx.sigCtxIdAbs()
also when sig_flag is inferred (except for the last scanning position,
where a different mechanism is used).

There is no impact on coding efficiency.

According to specification, alf_luma_coeff_delta_sign = 1 means that filtCoeff is negative. Idem with alf_chroma_coeff_delta_sign and AlfCoeffC.

According to specification, alf_ctb_flag is parsed for Cb when (slice_alf_chroma_idc = 1 or slice_alf_chroma_idc = 3), and for Cr when (slice_alf_chroma_idc = 2 or slice_alf_chroma_idc = 3).

use position and data from chroma unit when treeType = DUAL_TYPE_CHROMA to derive context

Johannes Sauer authored 5 years ago and Karsten Suehring committed 5 years ago

turn on debugging output when ENABLE_TRACING is set

Fix the huge loss in rate control with the macro WCG_EXT enabled by In-Loop Reshaping by saving the unadjusted lambda for RD cost before encoding current CTU.
This commit has removed the macro as recommended.

- create own files for HRD classes
- rename HRD to HRDParameters
- create HRD class that can hold all HRD related parameters as base for encoder/decoder specific implementations

diverges from current draft, thus using EMULATION_PREVENTION_FIX macro to mark changes

Fix ticket #267 on wrong SAD calculation in xGetSAD_NxN_SIMD(...) if rcDtParam.subShift is not equal to zero and input size is equal to 4x4.

patch-by: Tobias Hinz

Added:
* RDPCM_Y/Cb/Cr
* BDPCM
* TileIdx
* MTSFlag
* LFNSTIdx
* RegularMergeFlag
* SMVDFlag
* SbtIdx, SbtPos
* MIPFlag
* ISPMode
* JointCbCr
* ComAlphaCb/Cr (cross component prediction)
Removed:
* IBCFlag, IBC is signalled as part of PredMode

- includes special handling for dps ID equal to zero (JVET-N0869)
- writing of parameter set can be enabled by parameter EnableDecodingParameterSet

Xiang Li authored 5 years ago and Karsten Suehring committed 5 years ago

Fixed the encoder bug which leads to incorrect BVd signaling. The incorrect BVd triggers exception on valid BV checking.

implements:
- splitting tiles into bricks
- raster-scan tiles
- uniform and non-uniform splits
- all tiles/bricks in one slice
- each brick one slice
- PPS syntax

missing:
- rectangular tiles
- slice header syntax

further todo:
- rework slice mode 2 to use multiple tiles for byte size matching
- lots of renaming (tile->brick)