The current code misses the first character of the string for some reason. Maybe a compiler problem.
Using a local variable fixed this.

Signed-off-by: Nikolai Shostak <nikolai.shostak@vicuesoft.com>

Includes:
- fix signalling of fixed frame rates in encoder
- fix computation of frame rate in decoder
- fix access to SPS/VPS data for frame rate computation in decoder
- code clean up

- manual reformatting:
  - try to shorten lines
  - keep blocks somewhat aligned
  - remove documentation comments
- make IBC flag bool
- add some braces
- add line breaks into longer functions
- move even longer functions into .cpp file
- move static variables and functions to the end

- move VPS and related classes into VideoParameterSet.h/cpp
- move SPS and related classes into SequenceParameterSet.h/cpp
- move PPS and related classes into PictureParameterSet.h/cpp
- rename ProfileLevelTier.h/cpp to ProfileTierLevel.h/cpp and move ProfileTierLevel class there

No other changes except for minor formatting/comment cleanup

Avoid duplicating variables and functions for each reference list

Should also fix memory allocation issues with PicHeader.

Avoid having a separate PTL count since we already have a size
for the vector containing the PTLs.

Add a size check to avoid writing into inexistant PTL. This may
avoid bug reports such as #1587

This reverts commit 21980b28.

- reset passed string argument
- remove unnecessary pointers
- don't add zero termination character to C++ string

Kirill Suverov authored 2 years ago and Nikolay Shostak committed 2 years ago

When method checkAlfNaluTidAndPicTid() is called for a Slice object
pointers to SPS and VPS are not yet set.

Methods setSPS() and setVPS() are called later for that Slice object.

Since IDs of SPS and VPS are known at this point,
SPS and VPS can be found in ParameterSetManager.