Jonathan Taquet authored 5 years ago and Karsten Suehring committed 5 years ago

includes offline discussed replacement of tb(v) by ue(v) coding for alf_chroma_num_alt_filters_minus1

It cleans up old ISP code that is no longer used anymore. The code was used to allow only one ISP split depending on the block size. However, this functionality is not needed anymore after the adoption of JVET-N0308 during the Geneva Meeting in March, which limited the usage of ISP to CUs with a maximum size of 64x64 samples. This clean-up eliminates various unnecessary checks and improves the readability of the code.

replace AlfSliceParam by AlfParam and alfSliceParam by alfParam

Note: in VVC draft 6 "–	If intra_bdpcm_flag[ ][ ] is equal to 1, ctxInc is set equal to 1.", which was set equal to 4 in VTM5. This integration also implements this change, to align cbf ctx with VVC draft 6.

- LNFST is applied only on top of DCT-2

1. moving the cbf signaling from transform_tree() to transform_unit()
2. using transform depth 1 for coding chroma cbfs for CUs with SBT; solving the s/w bug reported in ticket #338

As reported in ticket #291, when sig_flag is inferred, the variables
m_tmplCpDiag and m_tmplCpSum1 are not set correctly, but used for
deriving the contexts for par_glag, gt1_flag, and gt3_flag.

The provided modification fixes this issue by calling cctx.sigCtxIdAbs()
also when sig_flag is inferred (except for the last scanning position,
where a different mechanism is used).

There is no impact on coding efficiency.