Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • V VVCSoftware_VTM
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Custom issue tracker
    • Custom issue tracker
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • jvet
  • VVCSoftware_VTM
  • Merge requests
  • !1058

Fix for #572: fix perceptual QP adaptation for unequal Cb and Cr QP offsets and in combination with JCCR

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christian Helmrich requested to merge crhelmrich/VVCSoftware_VTM:QPA-fixes into master Oct 24, 2019
  • Overview 2
  • Commits 7
  • Pipelines 5
  • Changes 5

see ticket https://jvet.hhi.fraunhofer.de/trac/vvc/ticket/572

In the case of unequal Cb and Cr QP offsets, the following encoder functions may, according to my understanding, work suboptimally:

  • rate control (if pCfg->getUseRateCtrl() in encodeCtus(), not sure if this is used)
  • perceptual QPA with chroma QP adaptation (e.g., if pCfg->getUsePerceptQPA() && pcSlice->getPPS()->getUseDQP() in encodeCtus())
  • SBT fast algorithm (InterSearch::calcMinDistSbt() called in xEncodeInterResidual()).

The last case is NOT fixed by this merge request since it would affect the HDR class 1 CTCs. See the attached hdr__vtm6_vs_vtm6withFix572.xlsm

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: QPA-fixes