JVET-Q0346 aspect 1: LMCS enabled flag in SH
JVET-Q0346 aspect 1: Adding slice level control of LMCS by a new LMCS enabled flag in SH
Merge request reports
Activity
added 1 commit
- 7fc80fe5 - Perform initialization of m_lmcsEnabledFlag in the right place
mentioned in commit 2f88809b
1109 1109 } 1110 1110 #endif 1111 1111 1112 #if JVET_Q0346_LMCS_ENABLE_IN_SH 1113 if (pSlice->getLmcsEnabledFlag() && lmcsAPS == nullptr) This instance should probably still use the picHeader version. For example, if the first slice in a picture has LMCS disabled, the following line:
picHeader->setLmcsAPS(lmcsAPS);
is going to erase the picture header m_lmcsApsId (will set it to -1), and the PH LMCS APS ID will not be available for future slices that may have LMCS enabled. That will trigger the "No LMCS APS present" error.
644 644 if (cs.sps->getUseLmcs() && m_cReshaper.getSliceReshaperInfo().getUseSliceReshaper()) 645 645 { 646 646 CHECK((m_cReshaper.getRecReshaped() == false), "Rec picture is not reshaped!"); 647 647 m_pcPic->getRecoBuf(COMPONENT_Y).rspSignal(m_cReshaper.getInvLUT()); mentioned in merge request !1454 (merged)
Thanks Brian for reporting on these two issues. I agree with both of them. I just submitted suggested fixes in MR !1454 (merged) . Can you please take a look and let me know what you think.
