Skip to content
Snippets Groups Projects

JVET-R0041: Picture types related constraints

Merged JVET-R0041: Picture types related constraints
ZhipinDeng/VVCSoftware_VTM:R0041 into master
1 unresolved thread
Merged Zhipin Deng requested to merge ZhipinDeng/VVCSoftware_VTM:R0041 into master
1 unresolved thread

Merge request reports

Merge request pipeline #5057 passed

Stage: build

Merge request pipeline passed for 7488ff82

Approval is optional

Merged by Karsten SuehringKarsten Suehring 4 years ago (Jun 12, 2020 10:53am UTC)

Merge details

  • Changes merged into master with befdfd07.
  • Did not delete the source branch.

Pipeline #5063 passed

Stage: build

Pipeline passed for befdfd07 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karsten Suehring
  • Karsten Suehring
  • Karsten Suehring
  • Zhipin Deng added 6 commits

    added 6 commits

    Compare with previous version

    Toggle commit list
  • Zhipin Deng added 1 commit

    added 1 commit

    Compare with previous version

  • Karsten Suehring resolved all threads

    resolved all threads

  • Karsten Suehring merged

    merged

  • Karsten Suehring mentioned in commit befdfd07

    mentioned in commit befdfd07

  • Remy Foray
    Remy Foray @forayr started a thread on the diff
    • source/Lib/CommonLib/Slice.cpp
    1218 1316 }
    1219 1317 }
    1220 1318 }
    1319 #endif
    1221 1320
    1222 // When a picture is a leading picture, it shall precede, in decoding order,
    1223 // all trailing pictures that are associated with the same IRAP picture.
    1321 #if JVET_R0041
    1322 if (pcSlice->getPicHeader()->getPicOutputFlag() == 1 && !this->getPicHeader()->getNoOutputBeforeRecoveryFlag() && pcPic->layerId == this->m_nuhLayerId)
    1323 {
    1324 if (this->getPOC() == this->getPicHeader()->getRecoveryPocCnt() + this->getPrevGDRInSameLayerPOC())
    • Remy Foray
      Remy Foray @forayr ·
      Contributor

      On a GDR picture, this check add the previous GDR poc with the new recovery_poc_cnt. The compliance check is therefore wrong on these picture.

      Furthermore, it is called even if there is no GDR in the stream. A RADL with poc -1 after a CRA with poc 0 will be signaled as not compliant, as all is initialized to 0!

    • Zhipin Deng
      Zhipin Deng @ZhipinDeng ·
      Author Contributor

      Thanks for pointing out this issue. I created MR !1687 (merged) trying to fix this bug. Would you please have a try?

      Edited by Zhipin Deng
    • Remy Foray
      Remy Foray @forayr ·
      Contributor

      The fix works for me. Thanks.

    • Please register or sign in to reply
  • Zhipin Deng mentioned in merge request !1687 (merged)

    mentioned in merge request !1687 (merged)

  • Karsten Suehring mentioned in commit 4885c797

    mentioned in commit 4885c797

    • Please register or sign in to reply