Skip to content
Snippets Groups Projects

JVET-S0234: ACT and chroma residual scaling fix

Merged JVET-S0234: ACT and chroma residual scaling fix
jamesxxiu/VVCSoftware_VTM:JVET_S0234_ACT_CRS_FIX into master
1 unresolved thread
Merged Xiaoyu Xiu requested to merge jamesxxiu/VVCSoftware_VTM:JVET_S0234_ACT_CRS_FIX into master
1 unresolved thread

JVET-S0234: moving chroma residual scaling after inverse ACT

Merge request reports

Merge request pipeline #5256 passed

Stage: build

Merge request pipeline passed for aa081fce

Approval is optional

Merged by Xiang LiXiang Li 4 years ago (Jul 16, 2020 6:44pm UTC)

Merge details

  • Changes merged into master with ebaa3734 (commits were squashed).
  • Did not delete the source branch.

Pipeline #5326 passed

Stage: build

Pipeline passed for ebaa3734 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Xiaoyu Xiu added 1 commit

    added 1 commit

    • 35090d5c - Fix the prefix problem of some variables names; change the macro from...

    Compare with previous version

  • Frank Bossen resolved all threads

    resolved all threads

  • Xiaoyu Xiu added 40 commits

    added 40 commits

    Compare with previous version

  • Xiang Li merged

    merged

  • Xiang Li mentioned in commit ebaa3734

    mentioned in commit ebaa3734

  • Brian Heng
    Brian Heng @bheng started a thread on the diff
    • source/Lib/DecoderLib/DecCu.cpp
    788 802
    789 803 //===== reconstruction =====
    790 804 const Slice &slice = *cs.slice;
    805 #if JVET_S0234_ACT_CRS_FIX
    806 if (!currTU.cu->colorTransform && slice.getPicHeader()->getLmcsEnabledFlag() && isChroma(compID) && (TU::getCbf(currTU, compID) || currTU.jointCbCr)
    • Brian Heng
      Brian Heng @bheng ·
      Contributor

      This seems to have broken slice-based LMCS control. The condition used to be based on slice.getLmcsEnabledFlag() and now it's based only on PicHeader()->getLmcsEnabledFlag().

    • Xiaoyu Xiu
      Xiaoyu Xiu @jamesxxiu ·
      Author Contributor

      Thanks a lot for identifying the problem. One MR!1853 was submitted for fixing such issue by replacing PicHeader()->getLmcsEnabledFlag() by slice.getLmcsEnabledFlag(). Please take a look. Thanks.

    • Please register or sign in to reply
    Please register or sign in to reply