Skip to content
Snippets Groups Projects

Fix #1464: Non-conforming values of sn_subpic_id_len_minus1

Merged Fix #1464: Non-conforming values of sn_subpic_id_len_minus1
hallapur/VVCSoftware_VTM:fix_1464_sn_subpic_id_len into master
1 unresolved thread
Merged Antti Hallapuro requested to merge hallapur/VVCSoftware_VTM:fix_1464_sn_subpic_id_len into master
1 unresolved thread

Fix sn_subpic_id_len_minus1 by calculating it always based on maximum subpic ID of the picture.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
source/Lib/EncoderLib/SEIEncoder.cpp
443 443 scalableNestingSEI->m_snSubpicFlag = 1;
444 444 scalableNestingSEI->m_snNumSubpics = (uint32_t) subpictureIDs.size();
445 445 scalableNestingSEI->m_snSubpicId = subpictureIDs;
446 scalableNestingSEI->m_snSubpicIdLen = max(1, ceilLog2((*std::max_element(subpictureIDs.begin(), subpictureIDs.end())) + 1));
446 scalableNestingSEI->m_snSubpicIdLen = max(1, ceilLog2(maxSubpicIdInPic + 1));
447 447 CHECK ( scalableNestingSEI->m_snSubpicIdLen > 15, "Subpicture ID too large. Length must be <= 15 bits");
  • Antti Hallapuro added 1 commit

    added 1 commit

    • 57c25d73 - Fix check for maximum subpic id len

    Compare with previous version

  • Frank Bossen merged

    merged

  • Frank Bossen mentioned in commit 7512abae

    mentioned in commit 7512abae

    • Please register or sign in to reply