Skip to content
Snippets Groups Projects

Fix #1498: Fix decoder mismatch for RGB content when LFNST is disabled

Merged Fix #1498: Fix decoder mismatch for RGB content when LFNST is disabled
All threads resolved!
All threads resolved!

Though Fix#1497 removed the encoder crash, it also inadvertently changed the behaviour when LFNST is disabled as the original code the loop upper bound can change during the processing of the loop. This did not happen in the fix and this generated decoder mismatches.

This fix replaces the simpler #1497 fix but maintains the existing behaviour when LFNST is disabled.

This fix has been tested with the 5 RGB sequences in the HBD CTC (single frame AI at 6 QP) and the 8 RGB TGM sequences in the non-420 CTC (single frame AI at 4 QP).

For the following configurations identical results were achieved with and without the fix (i.e. the code prior to #1497) LFNST=1, TS=1, BDPCM=1 LFNST=1, TS=1, BDPCM=0 LFNST=1, TS=0, BDPCM=0 LFNST=0, TS=1, BDPCM=0 LFNST=0, TS=1, BDPCM=1

For the following configuration results were obtained with the fix. Without the fix all encoder simulations resulted in SEGV. LFNST=0, TS=0, BDPCM=0

My apologies for the erroneous fix #1497.

Merge request reports

Merge request pipeline #6448 passed

Merge request pipeline passed for 4ee682bd

Merged by Xiang LiXiang Li 3 years ago (Aug 3, 2021 7:19am UTC)

Loading

Pipeline #6457 passed

Pipeline passed for 20dc81ce on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Adrian Browne added 1 commit

    added 1 commit

    • 4ee682bd - Simplified for loop to increase readability

    Compare with previous version

  • Author Contributor

    Attempted to simplify for loop by extracting an element into a break statement.

    The loop structure is complicated as LFNST does not use the trModes structure in all cases.

    I wonder if the readability of the code would be improved by having two loops - one for LFNST and one for non-LFNST - but that is beyond the scope of this fix.

  • Xiang Li resolved all threads

    resolved all threads

  • Xiang Li approved this merge request

    approved this merge request

  • merged

  • Xiang Li mentioned in commit 20dc81ce

    mentioned in commit 20dc81ce

  • Please register or sign in to reply
    Loading