Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • V VVCSoftware_VTM
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Custom issue tracker
    • Custom issue tracker
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • jvet
  • VVCSoftware_VTM
  • Merge requests
  • !247

Fix: Prevents usage of wrong contexts in DepQuant

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Heiko Schwarz requested to merge schwarz/VVCSoftware_VTM:fix-ctx-usage-in-depQuant into master Feb 05, 2019
  • Overview 4
  • Commits 2
  • Pipelines 2
  • Changes 1

The suggested changes fix the following two issues:

[1] For blocks with width>32 or height>32, the scan created in initRom() (file Rom.cpp) are only valid for the non-zero-out region. However, in Rom::xInitScanArrays() (file DepQuant.cpp), the zero-out region is also used. This has the effect that the array raster2id[] contains wrong values. As a consequence, wrong neighboring positions cpos[] are derived.

Even though a previous fix (fix #161) ensures that the positions are clipped to a value inside the subblock, these positions could still be wrong. It is suggested to fix the issue by correctly considering the zero-out regions for larger blocks (which is the actual source of the problem).

[2] In State::updateStateEOS(..), the array m_absLevelAndCtxInit should be set equal to zero if a skipped subblock is selected. Otherwise, it could be possible lead to a usage of wrongs contexts for following transform coefficients.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-ctx-usage-in-depQuant