Remove macros for HLS syntax element read/write

Removes Macro defintions for reading writing HLS.

Small code improvements have been added:

• fix variable names
• fix xReadString() function
• remove code duplication in VLC reading

resolved all threads

added 1 commit

• b0a6e131 - Remove case distinction for method declaration

Compare with previous version

@bossen I just made a search/replace for the function calls and didn't look through the coding style of all HLS functions.

There is probably another 2k lines patch open for renaming all uiCode and iCode variables (where a prefix is sometime actually useful to have a signed and unsigned temporary variable).

Do you want the style changes mixed into this one?

added 1 commit

• 1b24b9d9 - fix some style issues in SEIwrite.cpp

Compare with previous version

added 2 commits

• 05d3fcfd - Revert "Avoid code duplication in VLC reading functions"
• a8ee9233 - Replace assert with CHECK (where appropriate)

Compare with previous version

While testing the assert changes, I notices a bug in 21980b28. I had to revert that refactoring, because it is faulty.

resolved all threads

approved this merge request

Should we wait for !2482 (merged) before merging this?

Probably yes. The code there will have to be updated.

added 28 commits

• a8ee9233...2bb059f5 - 18 commits from branch jvet:master
• cc7999e9 - Remove HLS write macros
• 8be4498e - Remove decoder HLS macros
• 7dbf828a - Fix trace when writing VLC codes
• 1117e950 - Fix xReadString() function
• 9a94cacb - Avoid code duplication in VLC reading functions
• 8dddc1f4 - Remove case distinction for method declaration
• 35516220 - fix some style issues in SEIwrite.cpp
• d0890eea - Revert "Avoid code duplication in VLC reading functions"
• aeb96d4c - Replace assert with CHECK (where appropriate)
• 2dc9b302 - Fix code that was added to master in xWriteSEIPostFilterHint

Compare with previous version

I rebased after the merge.

merged

mentioned in commit a63bd2ce