Skip to content
Snippets Groups Projects

Fix for ticket 230, wrong memory bandwidth in DMVR

Merged Ryoji HASHIMOTO requested to merge hashimry/VVCSoftware_VTM:Fix_mem_band_dmvr into master
All threads resolved!

no effect to usual encoding and decoding, all added codes are active only when specific define is on.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Xiang Li resolved all discussions

    resolved all discussions

  • merged

  • Xiang Li mentioned in commit 1dfbb031

    mentioned in commit 1dfbb031

  • Jeeva Raj A
    Jeeva Raj A @jeeva.raj started a thread on commit 6cbafc14
  • 1940 1950
    1941 1951 xPrefetchPad(pu, m_cYuvRefBuffDMVRL1, REF_PIC_LIST_1);
    1942 1952
    1953 JVET_J0090_SET_CACHE_ENABLE( false );
    • Eventhough memory bandwidth measurement is disabled here to not factor while xinitMC and xFinalPaddedMCForDMVR, It is re-enabled inside predInterBlk in the following place, which makes the memory bandwidth measurement wrong.

      JVET_J0090_SET_CACHE_ENABLE( true ); if (bioApplied && compID == COMPONENT_Y) { const int shift = std::max(2, (IF_INTERNAL_PREC - clpRng.bd)); const Pel* refPel = refBuf.buf - refBuf.stride - 1; Pel* dstPel = m_filteredBlockTmp[2 + m_iRefListIdx][compID] + dstBuf.stride + 1; for (int w = 0; w < (width - 2 * BIO_EXTEND_SIZE); w++)

    • How about enabling cache "true" in InterPrediction::xPredInterBlk only when dmvrWidth == 0?

      The default value of dmvrWidth is 0 for this function call.

    • dmvrWidth is equal 0 for xPredInterBlk call in xFinalPaddedMCForDMVR, it is non zero only in xinitMC Need to add seperate variable to differentiate the predInterBlk called from DMVR or not.

    • you can enable cache "true" in InterPrediction::xPredInterBlk only srcPadBuf == NULL

    • Please register or sign in to reply
    Please register or sign in to reply
    Loading