Skip to content
Snippets Groups Projects

fix for ticket #281: Different encoder log on Windows and Linux

Merged fix for ticket #281: Different encoder log on Windows and Linux
JT/VVCSoftware_VTM:fix_#281 into master
Merged Jonathan Taquet requested to merge JT/VVCSoftware_VTM:fix_#281 into master
  1. Jul 03, 2019
    • Jonathan Taquet's avatar
      fix for ticket #281 · 6f8f5f65
      Jonathan Taquet authored 
      Refactor AlfCovariance::getClipMax loop:

This refactoring solve the issue with VS2017 in Release mode, where test
"if (E[clip_max[k]][0][k][l] != E[clip_max[k]+1][0][k][l])" was sometime true when it should have been false
(noticed with clip_max[k] == 1, i.e. during second iteration of while loop).

Some alternative tries: casting E[][][][] in long long, using std::abs(a-b) < 1,
or using std::abs(a-b) < std::numeric_limits::epsilon() failed to solve the issue.

Note: no analysis of the generated assembly have been performed to really understand the problem
      6f8f5f65