Skip to content
Snippets Groups Projects

JVET-O0143 Removal of top_left_brick_idx and fixes for uniform tiles, JVET-O0236 Removal of a parsing dependency

All threads resolved!

JVET-O0143 Removal of top_left_brick_idx and fixes for uniform tiles JVET-O0236 Removal of a parsing dependency Note that in this branch code, JVET_O0145_ENTRYPOINT_SIGNALLING needs to be set to 0 for rectangular slices with uniform tiles to work

Merge request reports

Pipeline #2810 passed

Pipeline passed for 9a9f6374 on rickard:JVET-O0143_JVET-O0236_TICKET-432

Approval is optional

Merged by Karsten SuehringKarsten Suehring 5 years ago (Sep 23, 2019 10:03am UTC)

Merge details

  • Changes merged into master with 240eedcf.
  • Did not delete the source branch.

Pipeline #2813 passed

Pipeline passed for 240eedcf on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Xiang Li
  • Xiang Li
  • added 1 commit

    • 9a9f6374 - JVET-O0143 Added parameters to software manual, using empty brackets, using...

    Compare with previous version

  • Karsten Suehring resolved all threads

    resolved all threads

  • Is the entry point signalling problem a spec issue?

  • Author Contributor

    In VCLReader there is the following text under #if JVET_O0145_ENTRYPOINT_SIGNALLING: //TODO: Update this when JVET-O0143 is implemented to handle the case when current slice is rectangular slice. // Need to access the variable SliceBrickIdx[] which has dependency to BricksToSliceMap[] I believe this is the reason JVET_O0145_ENTRYPOINT_SIGNALLING needs to be set to 0 for the combination of tiles and rectangular slices to work. I have not studied the entry point signalling details, please check with the authors of JVET_O0145_ENTRYPOINT_SIGNALLING.

  • Thanks. I remember seeing that comment.

  • mentioned in commit 240eedcf

  • Generally, it would be preferred to have separate merge requests for each proposal. I still merged because we need to release soon.

    @hendry197 Could you check the implication for JVET-O0145?

  • Remy Foray mentioned in merge request !999 (merged)

    mentioned in merge request !999 (merged)

  • Remy Foray mentioned in commit c84cedf9

    mentioned in commit c84cedf9

  • mentioned in commit 7426bf13

  • Please register or sign in to reply
    Loading