Fix RPR issues

• Ticket 560: Unsafe use of reference picture PPS pointers.
• Ticket 561: Incorrect clipping at picture border and insufficient picture buffer margin.
• Ticket 562: Incorrect calculation of refHeight.
• Ticket 563: Interaction between RPR and BDOF.
• Ticket 568: Disable sub-PU grouping optimization with RPR.
• Ticket 569: Disable clipping of unscaled RPR motion vectors.
• Ticket 571: Fix multiplication overflow in scaled MV position.

added 22 commits

• faeddb8e...12fd7464 - 21 commits from branch jvet:master
• 7e017e8a - Merge branch 'master' into fix_rpr_issues

Compare with previous version

Thanks a lot for the fixes! It would be good to have separated fixes for different tickets. Is it convenient to do it?

Will this change be merged in the next couple of days? I need to integrate scaling window and phase shifts adopted for RPR, it will generate conflicts. I hoped to do it on top this merge request, but it is already opened for more than a week...

@XiangLi, It's not easy to redo as separate changes for separate tickets. Is it a problem to fix all the tickets with one commit? If you really need separate fixes, I probably won't get to that for a couple weeks.

I have ticket: #define RPR 1 // Fix RPR issues https://www.sendspace.com/file/fccbou

@bheng According to JVET-O1003 Guidelines for VVC reference software development, 7.1.2. Commits and patches should be for a single logical “change”, i.e. a single feature, single bug fix, etc. Such rule is to generally avoid the case that we have to revert a whole combined patch when one single thing is wrong in the whole patch.

We really appreciate your effort on fixing the issues. Maybe we can go back to this later. In the future, please avoid combined fixes. Thanks.

@XiangLi Ok, I've split them up as separate merge requests. Closing this MR then.

closed